Data Import Stabilization plan

Steps

Categories

See : Assessment ratings

  1. Performance: di-performance
  2. Stability/Reliability: di-data-integrity (more tags to be added)
  3. Scalability
  4. Architecture
  5. Code quality

Priorities

High, Mid, Low

Complexity

S, M, L, XL, XXL

Table


CategoryProblem definitionBusiness impactProposed solution

Priority

DEV

Priority

PO

ComplexityExisting Jira item(s)Current feature(s)Final feature (s)
1PerformanceKafka producer closed after sendingLow performance of import

Create pool of active producers. Start pool on module launch, close on shutdown. Reuse connections.

Add max/min pool sizes.

High
L

MODDATAIMP-499 - Getting issue details... STATUS

UXPROD-3135 - Getting issue details... STATUS

UXPROD-3191 - Getting issue details... STATUS

2
WARN message when no handler foundnone

Do not subscribe to messages you're not going to process

OR

Lower log lever for this type of messages

Low
S

MODSOURCE-340 - Getting issue details... STATUS

UXPROD-3135 - Getting issue details... STATUS

UXPROD-3191 - Getting issue details... STATUS

3Stability/Reliability

Race condition on start (Kafka consumers start working before DB is configured)

OR

Periodical DB shutdown after SRS restart. Jobs get stuck if not able to update status in DB (messages ACKed even if we could not process them)

Imports might get stuck on module restart

Need investigation / check

Investigate the issue with DB (possible OOM on PG server)


Mid

MODSOURCE-339 - Getting issue details... STATUS

UXPROD-3135 - Getting issue details... STATUS

UXPROD-3193 - Getting issue details... STATUS

4

Performance

Stability/Reliability

High CPU/Memory consumption on modulesLow performance of import. Higher costs for hosting

Significantly decrease size of payload:

  1. Remove immutable parts. Instead fetch them on demand and cache locally for reuse.
  2. Change message handling mechanism (currently relies on pt1 - profile) (optional)
  3. Move archiving to Kafka instead of module level
High
XXL

MODDATAIMP-439 - Getting issue details... STATUS

MODSOURMAN-519 - Getting issue details... STATUS

MODINV-405 - Getting issue details... STATUS

MODINV-408 - Getting issue details... STATUS

MODINV-460 - Getting issue details... STATUS

MODINVOICE-251 - Getting issue details... STATUS

MODINVOICE-252 - Getting issue details... STATUS

MODPUBSUB-167 - Getting issue details... STATUS

MODSOURCE-286 - Getting issue details... STATUS

MODSOURCE-290 - Getting issue details... STATUS

MODSOURMAN-463 - Getting issue details... STATUS

MODSOURMAN-464 - Getting issue details... STATUS

MODSOURMAN-465 - Getting issue details... STATUS

MODSOURMAN-466 - Getting issue details... STATUS

MODSOURMAN-468 - Getting issue details... STATUS

MODSOURMAN-469 - Getting issue details... STATUS

MODSOURMAN-474 - Getting issue details... STATUS

MODSOURMAN-519 - Getting issue details... STATUS


UXPROD-3135 - Getting issue details... STATUS

UXPROD-3193 - Getting issue details... STATUS

5PerformanceKafka cache resource consumptionLow performance of import. Higher costs of hosting.Remove Kafka cache. Modules that do not do persistent changes will sometimes (on duplicates read) do unnecessary calls. Can be optimized further upon adding distributed in-memory cache (ex hazelcast) (blocked by 6)Mid
M

MODINV-444 - Getting issue details... STATUS

MODINV-401 - Getting issue details... STATUS


UXPROD-3135 - Getting issue details... STATUS

UXPROD-3191 - Getting issue details... STATUS

6Stability/ReliabilityDuplicates created upon importData inconsistency on import.Make consumers behave idempotent. Add pass-through identifier to de-duplicate messages. High
XL

MODDATAIMP-474 - Getting issue details... STATUS

MODDATAIMP-440 - Getting issue details... STATUS

MODDATAIMP-491 - Getting issue details... STATUS

MODDATAIMP-495 - Getting issue details... STATUS



UXPROD-3135 - Getting issue details... STATUS

UXPROD-3193 - Getting issue details... STATUS

7Stability/ReliabilityKafka consumers stop reading messages eventually, breaking job progress until module restart.Imports eventually get stuck until module restartNeed investigationHigh
?

MODINV-417 - Getting issue details... STATUS

UXPROD-3135 - Getting issue details... STATUS

UXPROD-3193 - Getting issue details... STATUS

8Code qualityTest coverage is not high enough (Unit)Higher amount of bugsWrite more testsMid
S

MODPUBSUB-168 - Getting issue details... STATUS


UXPROD-2697 - Getting issue details... STATUS

UXPROD-2697 - Getting issue details... STATUS

9Code qualityTest coverage is not high enough (Karate)Higher amount of bugsWrite more tests (define test cases)Mid
L

UXPROD-2697 - Getting issue details... STATUS

UXPROD-2697 - Getting issue details... STATUS

UXPROD-2697 - Getting issue details... STATUS

10Stability/Reliabilitymod-data-import stores input file in memory, limiting size of uploaded file and possibly having oomData import file size is limitedSplit to chunks, put to database, work with database/temp storage. Partially done (to be investigated)Mid
L

MODDATAIMP-390 - Getting issue details... STATUS

MODDATAIMP-392 - Getting issue details... STATUS

MODDATAIMP-465 - Getting issue details... STATUS

UXPROD-3135 - Getting issue details... STATUS

UXPROD-3193 - Getting issue details... STATUS

11PerformanceData import impacts other processesSlower response of system during data import

Need investigation (possible solution - configure rate limiter)

Relates to number 4




MODDATAIMP-517 - Getting issue details... STATUS

UXPROD-3135 - Getting issue details... STATUS

UXPROD-3191 - Getting issue details... STATUS

12PerformanceHigh resource consumption to get job(s) status/progressSlow performance of import and landing page.Add some kind of caching for progress tracking (database or in-memory)Low
S

MODSOURMAN-469 - Getting issue details... STATUS

UIDATIMP-918 - Getting issue details... STATUS

UXPROD-3135 - Getting issue details... STATUS

UXPROD-3191 - Getting issue details... STATUS

13Stability/ReliabilitySRS can fail when processing message during import
Import can end up creating some instances but not creating holdings/items for some MARC records

Generate "INSTANCE CREATED" from mod-inventory. Consume in SRS to update HRID in BIB and in INVENTORY to continue processing.


Remove unnecessary topics (* ready for post processing and hrid set)

Mid
L

MODDATAIMP-500 - Getting issue details... STATUS

UXPROD-3135 - Getting issue details... STATUS

UXPROD-3193 - Getting issue details... STATUS

14Stability/Reliability

If we have infrastructure issue (like DB not available, module being restarted or network failure), we are sending DI_ERROR instead of retrying

Records that can potentially be processed during import are not processed if we have temporary infrastructure issues (DB down, network connectivity loss, etc)

Do not ACK messages in Kafka if there's not a logic, but infrastructure error/exception. Split failed processing results into 2 categories:

  1. IO errors - do not ack. retry until fixed
  2. Business logic - DI_ERROR and Ack current message
Mid

MODDATAIMP-501 - Getting issue details... STATUS

UXPROD-3135 - Getting issue details... STATUS

UXPROD-3193 - Getting issue details... STATUS

15
Consumer gets disconnected from Kafka clusterJobs get stuck until module restartNeed investigationMid

MODINV-417 - Getting issue details... STATUS

UXPROD-3135 - Getting issue details... STATUS

UXPROD-3193 - Getting issue details... STATUS

16
De-duplication of status messages for progress barProgress bar might display incorrect progressDe-duplicate status messages per-record while tracking progressMid
L (depends on 12)

MODSOURMAN-522 - Getting issue details... STATUS

UXPROD-3135 - Getting issue details... STATUS

UXPROD-3193 - Getting issue details... STATUS

Filters

key summary type created updated due assignee reporter priority status resolution
Loading...
Refresh

Issues to potentially remove from scope

MODDATAIMP-410 - Getting issue details... STATUS

MODDATAIMP-430 - Getting issue details... STATUS

MODDATAIMP-444 - Getting issue details... STATUS

MODSOURCE-300 - Getting issue details... STATUS

MODSOURMAN-481 - Getting issue details... STATUS

MODSOURMAN-521 - Getting issue details... STATUS

Links

Data Import Observations for Improvements