ERM Sprint 142

Owned by Jag Goraya
Last updated: Jun 15, 2022
4 min read

Sprint Goal / Focus

  • Regression Fixes

Sprint Schedule

Development Meetings

  • 15 Jun 2022
  • 22 Jun 2022

Sprint Capacity

Team Availability: Schedule | Calendar

Notes / Exceptions:

  • Peter: Thu 16 Jun 
  • Claudia: 6-17 Jun

Lead Roles:

QA Environment: folio-snapshot

Present

Planning Questions

  • Does the issue meet the criteria for Definition of Ready?
  • What front and back end components are affected?
  • What changes need to be made? (additions, removals or modifications)
  • What development tests need to be written?  
  • What data does the developer need to verify their work?
  • What are the known unknowns? 
  • What is needed to QA? (environment, data, scripts)

Navigation

 Sprint Planning Agenda
  1. Sprint Goal / Focus
  2. Sprint Capacity
  3. Review sprint candidates 
  4. Agree technical approach / define key implementation tasks
  5. Finalise estimates / costings
  6. Confirm sprint scope
  7. Confirm first actions




Sprint Planning  

(error) - not in sprint

(tick) or @ - in sprint 


Planning Notes Template

  • Approach
  • Components and Changes
    • Frontend
    • Backend
  • Tests / Data
  • Dependencies
  • Known Unknowns
  • QA: local | testing | snapshot | other
  • Development Estimate

Sprint Focus

https://issues.folio.org/browse/ERM-2134
Feature ID

Issue ID

Sprint Backlog?

Notes / Estimates / Actions


 ERM-2201 - Getting issue details... STATUS

Ethan Freestone 

Code for multi-value property has broken single-value properties. 

  • Approach
    • Add debug into binding to isolate issue
    • Check each web binding for single and multi-value individually
    • Domain class is exposed by library, so not easy to test in web-toolkit
  • Components and Changes
    • Frontend: NA
    • Backend: web-toolkit, dependency bump for mod-licenses, mod-agreements
  • Tests / Data: NA
  • Dependencies / Known Unknowns: NA
  • QA: snapshot 
  • Development Estimate: ??

ERM-2203 - Getting issue details... STATUS

Monireh Rasouli 

  • Approach
    • only GET if there is 
    • hook: useCustomProperties
    • pass enabledProp query parameter to only fire if >1 license
  • Components and Changes
    • Frontend: ui-agreements/agreement.js
    • Backend: NA
  • Tests / Data: NA
  • Dependencies / Known Unknowns: 
  • QA: snapshot 
  • Development Estimate: 1d

ERM-2204 - Getting issue details... STATUS

(tick) Monireh Rasouli 

  • Approach
    • add callout from stripes-kint-components
    • add default message
    • allow message to be overwritten
    • implement override function to agreements & licenses
  • Components and Changes
    • Frontend: stripes-kint-components, ui-agreements, ui-licenses
    • Backend: none
  • Tests / Data: no
  • Dependencies: required for stripes-kint-components 2.6.0
  • Known Unknowns
  • QA: snapshot 
  • Development Estimate: 1d

ERM-2205 - Getting issue details... STATUS

(question)
  • Approach
    • Check refdata is being passed 
    • Check that the issue is happening in other places that refdata is being used (CONFIRMED in licenses)
    • Check that new things are fetched (invalidation is working correctly)
    • Check we're not memo-ising the filter state (such as caching)
    • if we're not caching, where is the update happening (eg, in stripes) > then coordinate to force / trigger a refresh 
  • Components and Changes
    • Frontend: agreementFilters
    • Backend: none
  • Tests / Data: ?
  • Dependencies: ?
  • Known Unknowns: may be Stripes / SaS / StripesConnect related
  • QA: snapshot
  • Development Estimate: ? 

ERM-2206 - Getting issue details... STATUS

(question)
  • Approach
    • unlikely to be react, and sure we don't make second fetch for ISSN
    • find the component that is supposed to be rendering
    • if data is there, check shape path
    • if data not there and not in network, check view file on backend
  • Components and Changes
    • Frontend: ui-agreements
    • Backend: ? 
  • Tests / Data: test the shape still works
  • Dependencies / Known Unknowns: 
    • identifier property added at package and title level: shouldn't be an issue as we should not be filtering object by key
  • QA: snapshot
  • Development Estimate: 0.5d (path) 1d (view) 

ERM-2207 - Getting issue details... STATUS

(tick) Monireh Rasouli 

  • Approach
    • configuration.item.entries.post needed where configuration.item.entries.put is granted 
    • add entry to package.json 
  • Components and Changes
    • Frontend: all front-end modules apart from plugins and stripes-*-components
    • Backend: NA
  • Tests / Data: NA
  • Dependencies / Known Unknowns: NA
  • QA: snapshot
  • Development Estimate: 1d

ERM-2208 - Getting issue details... STATUS

(tick) Monireh Rasouli 

  • Approach
    • if paging works in places other than agreementLines, then key may be incorrect
    • fetch to mod-config may be using wrong lookup key or parsing out wrong key
    • works for agreements, not resources
      • function may be assuming default location 
      • useAgreementSettings hook
    • use debug to check returned output form lookup
    • use debug to check we are looking in the right place
  • Components and Changes
    • Frontend: ui-agreements
    • Backend: NA
  • Tests / Data / Dependencies / Known Unknowns: none
  • QA: snapshot
  • Development Estimate: 1d

ERM-2209 - Getting issue details... STATUS

Peter Böhm 
  • Approach
    • add nullable true constraint to fields in schema
    • (should already be nullable on domain classes)
  • Components and Changes
  • Tests / Data: NA
  • Dependencies: / Known Unknowns: NA
  • QA: snapshot
  • Development Estimate: 0.5d


Release Tasks 

Feature ID

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

ERM-2157 - Getting issue details... STATUS

ERM-2155 - Getting issue details... STATUS

Ethan Freestone 

For ERM-2157 - Getting issue details... STATUS

ERM-2157 - Getting issue details... STATUS

ERM-2182 - Getting issue details... STATUS

Ethan Freestone 

For ERM-2157 - Getting issue details... STATUS

ERM-2157 - Getting issue details... STATUS

ERM-2158 - Getting issue details... STATUS

Ethan Freestone 

For ERM-2157 - Getting issue details... STATUS




Planning Notes Template

  • Current State
  • TODO
  • Development Estimate

Rolled Over From Previous Sprint

Sprint Backlog

Feature IDIssue IDSprint Backlog?

Notes / Estimates / Actions

UXPROD-3591 - Getting issue details... STATUS

ERM-2094 - Getting issue details... STATUS

(question)

ERM-2134 - Getting issue details... STATUS

(question)


STRIPES-675 - Getting issue details... STATUS

ERM-2153 - Getting issue details... STATUS

Ethan Freestone 

See what can be done for 2.6.0 release

ERM-2174 - Getting issue details... STATUS

Ethan Freestone 

  • Approach
    • need to check GSON files
  • Components and Changes
    • Frontend
    • Backend
  • Tests / Data
  • Dependencies
  • Known Unknowns
  • QA: local | testing | snapshot | other
  • Development Estimate

ERM-2184 - Getting issue details... STATUS

(error)

STRIPES-675 - Getting issue details... STATUS

ERM-2148 - Getting issue details... STATUS

Claudia Malzer 


STRIPES-675 - Getting issue details... STATUS

ERM-2151 - Getting issue details... STATUS

Claudia Malzer 



For Development

Feature IDIssue IDSprint Backlog?

Notes / Estimates / Actions

UXPROD-3591 - Getting issue details... STATUS

ERM-2172 - Getting issue details... STATUS

Peter Böhm 

  • Current State: 
    • Outstanding problems: ERM-2172 - Getting issue details... STATUS
      • lookUporCreateContentType
        • has to be invoked as a static refdata method
      • alternate resource name
        • line 148 should be in line 145
        • collection needs to be added one by one, and then merged together at the end
      • null-proof empty lists
        • should be resolved by switching up for alt resource name (remove lines 149-150)
        • no need to assign an array, but put it directly into the pkg
        • may need to def it for grails
  • TODO: 
    • check whether collection is nullable by default
  • Development Estimate: Wed 1 Jun / Mon 16 May EOD / Mon 9 May / Thu 5 May / Wed 13 Apr

UXPROD-3406 - Getting issue details... STATUS

ERM-2157 - Getting issue details... STATUS



Monireh Rasouli 

  • Current State
    • All developed and tests written. 
  • ISSUES
    • TO FIX. Three components failing (custom properties settings, views)
  • TODO
    • TO FIX. Custom Properties Settings and View tests
  • Development Estimate: 1 Jun (with tests, assuming permissions issues resolved)

ERM-2202 - Getting issue details... STATUS

Ethan Freestone 

In Code Review. Waiting for stripes-kint-components release. 



For QA

Feature IDIssue IDSprint Backlog?

Notes / Estimates / Actions

UXPROD-3335 - Getting issue details... STATUS

ERM-1850 - Getting issue details... STATUS

Owen Stephens

Currently not testable:

  • Don't currently harvest through Title Only harvest
  • Only triggered once daily. 
  • Need to be able to trigger on snapshot. 

To test:

  • Need to set up a Title KB
  • Reset cursor, potentially via postman ... no endpoint (as doesn't go through okapi)

Otherwise - can test locally


ERM-2173 - Getting issue details... STATUS

Owen Stephens 



ERM-2120 - Getting issue details... STATUS

Owen Stephens 



ERM-2061 - Getting issue details... STATUS

Owen Stephens 



ERM-2066 - Getting issue details... STATUS

Owen Stephens 



ERM-2085 - Getting issue details... STATUS

Owen Stephens 



ERM-2092 - Getting issue details... STATUS

Owen Stephens 

ERM-2135 - Getting issue details... STATUS

Owen Stephens



ERM-2175 - Getting issue details... STATUS

Owen Stephens



For Elaboration

Feature IDIssue IDSprint Backlog?

Notes / Estimates / Actions






For Release Prep

Feature IDIssue IDSprint Backlog?

Notes / Estimates / Actions

UXPROD-2337 - Getting issue details... STATUS

ERM-778 - Getting issue details... STATUS

Owen Stephens


UXPROD-3591 - Getting issue details... STATUS

ERM-2060 - Getting issue details... STATUS / 

ERM-2076 - Getting issue details... STATUS / 

ERM-2046 - Getting issue details... STATUS

Owen Stephens


UXPROD-3591 - Getting issue details... STATUS

ERM-2059 - Getting issue details... STATUS  

Owen Stephens 


UXPROD-3427 - Getting issue details... STATUS

ERM-1979 - Getting issue details... STATUS

Owen Stephens 


UXPROD-3581 - Getting issue details... STATUS

ERM-1986 - Getting issue details... STATUS

Owen Stephens  


UXPROD-3410 - Getting issue details... STATUS

ERM-2043 - Getting issue details... STATUS

Owen Stephens 

UXPROD-3407 - Getting issue details... STATUS

ERM-2044 - Getting issue details... STATUS

Owen Stephens


UXPROD-2337 - Getting issue details... STATUS

ERM-2048 - Getting issue details... STATUS

Owen Stephens


UXPROD-2337 - Getting issue details... STATUS

ERM-2068 - Getting issue details... STATUS

Owen Stephens



Bugfix Cycle

Feature IDIssue IDSprint Backlog?

Notes / Estimates / Actions






Brought In

Feature IDIssue IDSprint Backlog?

Notes / Estimates / Action





Removed

Feature IDIssue IDSprint Backlog?

Notes / Estimates / Actions







Sprint Summary

ERM

key summary type assignee status components
Refresh


Dashboard

key summary type assignee status components
Refresh

Other

key summary type assignee status components
Refresh