Firebird - Definition of Done

Please note that all items in checklist marked with [M] are mandatory.


Checklist

User Story/Bug

System Demo/Review

Release

[M] Implementation of requirements is completed and acceptance criteria have been met.Y

[M] Unit/API tests are written and are passing (for API test screenshot of test run is added). At least 80% code coverage is expected (for new code) and 100% is preferred for critical code.

Y



[M] Browser testing completed (if applicable) Y

[M] Performance tests completed (if applicable) Y

[M] Check the lists to make sure they show at least 11 items, which means the limit was explicitly set and default 10 items limit is not applied Y

[M] Accessibility check list is considered.Y

[M] UI: Check if required permissions are set for new endpoints (if applicable)


[M] Pull request is created, reviewed and approved by 2 other developers

Y



[M] Required updates are implemented based on comments to Pull request.

Y



[M] Fix code smells, security vulnerabilities, lint errors that are reported by Sonarqube and other tools in CI pipeline before merging code to master

Y



[M] Existing API tests (backend modules) and Integration tests (UI modules) are maintained/implemented/improved and pass

Y



[M] Any configuration and/or build scripts are updated and tested

Y



[M] Data migration scripts are implemented for schema changesY

[M] Dev verification is performed by a developer on Vagrant Box/Rancher environment and issues resolved if found

Y



[M] Code is merged with all conflicts resolved and is available on https://folio-testing.aws.indexdata.com/ and folio-snapshot-stable.aws.indexdata.com Y

[M] QA is performed by a QA/developer on Integration (snapshots) environment and issues resolved if found

Y



[M] Updates are tested and accepted by PO 

Y



[M] No open critical bugs on any user stories


Y


[M] DoD of each user story, included in demo are met


Y


[M] All updates are demoed from the shared environment (folio-snapshot-stable.aws.indexdata.com or http://folio-testing.aws.indexdata.com/)

In case of some technical reasons we have to demo from local machines, it must be explicitly disclosed to the community and the reasons should be clarified.


Y


[M] Releases are created following: Release procedures and Regular FOLIO releases.



Y

[M] Installation and deployment scripts are updated



Y

[M] All critical bugs reported by QA, manual testing, UAT, PO etc. are fixed



Y

[M] User documentation updated (deployment documentation, scripts/packaging etc.) (if applicable)



Y