Thunderjet - Definition of Done
Please note that all items in checklist marked with [M] are mandatory.
Checklist | User Story/Bug | System Demo/Review | Release |
|---|---|---|---|
| [M] Implementation of requirements is completed and acceptance criteria have been met. | Y | ||
[M] Unit/API tests are written and are passing. At least 80% code coverage is expected and 100% is preferred for critical code. | Y | ||
| [M] Browser testing completed (if applicable) | Y | ||
| [M] Performance tests completed (if applicable) | Y | ||
[M] For FE issues: It shows 11 rows successfully in the list (without an explicit limit clause, all backend queries will use an implied limit of 10 rows. ) | Y | ||
| [M] Accessibility check list is considered. | Y | ||
[M] Localization is taken care of in application code | Y | ||
[M] Pull request is created, reviewed and approved by at least 2 other devs. | Y | ||
[M] Required updates are implemented based on comments to Pull request. | Y | ||
| [M] Code is merged with all conflicts resolved and is available on folio-snapshot.dev.folio.org or folio-snapshot-2.dev.folio.org | Y | ||
[M] Fix code smells, security vulnerabilities, lint errors that are reported by Sonarqube and other tools in CI pipeline before merging code to master | Y | ||
[M] Existing API tests (backend modules) and Integration tests (UI modules) are maintained/implemented/improved and pass | Y | ||
[M] Any configuration and/or build scripts are updated and tested | Y | ||
| [M] Data migration scripts are implemented for schema changes | Y | ||
[M] verify compliance with GDPR – future requirement | Y | ||
[M] QA is performed by a dev and issues resolved if found | Y | ||
[M] Feature is accepted by PO (Move the story to “in Review” and assign it to PO who will review and move it to Done if accepted) | Y | ||
[M] No open critical bugs on any user stories | Y | ||
[M] DoD of each user story, included in demo are met | Y | ||
[M] All demoable features are demoed from the same shared environment (folio-snapshot-stable.aws.indexdata.com or http://folio-testing.aws.indexdata.com/) In case of some technical reasons we have to demo from local machines, it must be explicitly disclosed to the community and the reasons should be clarified. | Y | ||
[M] Releases are created following: Release procedures and Regular FOLIO releases. | Y | ||
[M] Installation and deployment scripts are updated | Y | ||
[M] All critical bugs reported by QA, manual testing, UAT, PO etc. are fixed | Y | ||
[M] User documentation updated (deployment documentation, scripts/packaging etc.) (if applicable) | Y |