NOTE: Detailed notes weren't captured for today's meeting. For the most part the time was spent reviewing the Kanban board. We left comments on several JIRAs, but nothing worth explicitly noting here.
Mitigations are known and until edge modules are fixed a message should be posted
A backport to Kiwi is not needed because of easy to implement mitigation options:
Use different credentials for each tenant. OR
Remove the X-Okapi-Tenant HTTP header from requests to these edge modules.
Today:
Julian Ladisch to announce that in the appropriate channels
mod-configuration - should it be deprecated or not?
mod-configuration has been discussed on the development channel recently. Developers like it because they can simply drop variables to the/configurations/entriesAPI. Simply use the "configuration.*" permission shared by all modules and you are done. No need to add schema validation, no need to add dedicated permissions, no need to add a dedicated API. Drawbacks:
A big institution need config write permissions with module granularity. One member of staff may be allowed to edit circulation config but not aquisition config.
No validation. mod-configuration cannot validate a POST or PUT request because it doesn't know. Only the module it belong to knows this. Relevant use case: Using curl/wget/postman/...
No documentation. mod-configuration has no documentation, one needs to search, maybe the module's README has some? A dedicated module API always publishes the API documentation athttps://dev.folio.org/reference/api/
Performance. Requests to mod-configuration result in latency. If the config API belongs to the module the module can cache it and can invalidate the cache if the config is changed. Caching requests to mod-configuration will always result in a time period with outdated values. In mod-inventory-storage we've combined fetching the HRID config and HRID generation into a single SQL query.
Coupling. Modules should be loosely coupled and therefore each module should store its own configs.
It was requested that a formalRFC/Architecture Decision Recordbeen created if mod-configuration should no longer been used for module-specific configurations.
Team decided we want to have this as a RFC. Target should be to have this implemented within Nolana. Could discuss in your meetings while the RFC process moves on.
We need to communicate the expectation better - e.g. add something to the platform release notes indicate how long P1 security issues will be backported to that release.
As long as we upgrade to the latest LTS release of Spring Boot in each flower release, we should be in decent shape - only ~1 mo. where we're running a version of Spring boot that's no longer supported.
Note that we're currently a bit behind with this, even if we upgrade edge modules, etc. in a Lotus HF, kiwi and Juniper will be running older, unsupported versions for some period of time. Going forward we'll need to be diligent about this to avoid getting into this situation again.
Update? Have we added anything to the MG release notes?
Not yet... Craig McNally will refresh his memory on what we agreed to at previous meetings and will send out a strawman message in the slack channel for review.
Textproposal:
Morning Glory will receive security fixes for critical issues until Orchid is released (est. Spring 2023). Detailed information on particular issues will be provided by the security team. With this release there will be no other security hotfixes on Kiwi.
Put this text proposal for the release into a ADR to forward this to the TC
Julian Ladisch to set up that ADR - This is done and has been reviewed by the TC
Today:
The TC has discussed this, and feel uncomfortable to make the call on their own. They feel that the PC needs to be involved in the decision.
The TC will revisit next week - stay tuned for next steps
5 min
Update on
FOLIO-3317
-
Getting issue details...STATUS
Axel
Axel Dörrer Should be removed from week to week agenda and Axel will monitor for progress and report back
Leipzig Devs mentioned that filling up memory can not only be solved by a limit on uploads. It also should consider multiple simultainous uploads as scenario.
Axel Dörrer to check back with dev what other possibilities of implementation could be.
Last week it was noted that there was a slack conversation started about this. Need to check in on Oleksandr Bozhko's progress (he's was investigating the problem.
no news in the last 7 days... Craig McNally to nudge him and see where this stands.
Open PR on FOLIO-3448 (Documentation as a warning for developers)
Craig McNally to check if a new Jira has to be created for that and push on that
A helper has been developed by Julian to prevent this issue in new/changed code.
Mikhail F arranged a meeting for this Friday in order to explain all the details to Epam Team leads.
Today:
There's one aspect of this that's still deserves some discussion. It was identified by Julian Ladisch and raised to Mikhail. Presently awaiting a response/feedback.
5 min
edge-lti-courses
Team
edge-lti-courses has been unmaintained since July 2021. Open Jiras: