2022-08-04 Meeting notes

Date

Attendees

Discussion items

TimeItemWhoNotes
1 minmod-configuration - should it be deprecated or not?Julian Ladisch 

mod-configuration has been discussed on the development channel recently. Developers like it because they can simply drop variables to the /configurations/entries API. Simply use the "configuration.*" permission shared by all modules and you are done. No need to add schema validation, no need to add dedicated permissions, no need to add a dedicated API.
Drawbacks:

  • A big institution need config write permissions with module granularity. One member of staff may be allowed to edit circulation config but not acquisition config.
  • No validation. mod-configuration cannot validate a POST or PUT request because it doesn't know. Only the module it belong to knows this. Relevant use case: Using curl/wget/postman/...
  • No documentation. mod-configuration has no documentation, one needs to search, maybe the module's README has some? A dedicated module API always publishes the API documentation at https://dev.folio.org/reference/api/
  • Performance. Requests to mod-configuration result in latency. If the config API belongs to the module the module can cache it and can invalidate the cache if the config is changed. Caching requests to mod-configuration will always result in a time period with outdated values. In mod-inventory-storage we've combined fetching the HRID config and HRID generation into a single SQL query.
  • Coupling. Modules should be loosely coupled and therefore each module should store its own configs.


It was requested that a formal RFC/Architecture Decision Record been created if mod-configuration should no longer been used for module-specific configurations.

Team decided we want to have this as a RFC. Target should be to have this implemented within Nolana. Could discuss in your meetings while the RFC process moves on.


Today:

  • Julian not present this week.  I don't see an ADR or RFC yet.  Shift to next week
0 minKafka security Team

The topic of Kafka security was raised as part of a conversation at the TC yesterday.  

The Security Team should be aware of this and probably should weigh in on the topic, or even generate proposals if we have ideas for how to solve the problem.


Today:

  • On hold until the RFC is available for review.
5-10 minOWASPTeam

Jakub Skoczen  raised the idea of evaluating if FOLIO meets these standards.  Ryan Berger has run some tools a while back, but it's probably time to revisit, and maybe take it further.


Today:

  • Deferred until we have Jakub and Julian. 
  • Craig McNally can't recall the context for the action item above... What is this JIRA ticket about?  The automation of these checks, or something else?
10 minBrainstorm the cumulative upload problemTeam
  • Regarding file upload size issues (See FOLIO-3317 - Spike - investigate possible file upload vulnerability OPEN ), let's brainstorm ideas for mitigating the cumulative upload problem, not just he large file upload size problem.  
    • Some APIs are more vulnerable to this than others, such as those not protected by permissions - e.g. mod-login, edge APIs, etc.

Today:

  • Axel provided some background/context.  We still need to give this some thought and possibly suggest a solution

*

Review the Kanban boardTeam

Action items

  • Craig McNally will create the ticket and we can revisit in a future meeting (next week or two)